Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pos-consensus.md #298

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

ottovlotto
Copy link
Contributor

Updating 2x hyperlinks in "Block Production - BABE" section to link to the new "Randomness" page in the Developer Docs (vs the previous links to the equivalent Polkadot Wiki pages).

Updating 2x hyperlinks in "Block Production - BABE" section to link to the new "Randomness" page in the Developer Docs (vs the previous links to the equivalent Polkadot Wiki pages).
@ottovlotto ottovlotto requested a review from a team as a code owner January 7, 2025 09:53
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor tweaks

@nhussein11 nhussein11 self-requested a review January 8, 2025 13:32
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhussein11 nhussein11 merged commit 4ebcb3a into polkadot-developers:master Jan 8, 2025
1 check passed
@ottovlotto
Copy link
Contributor Author

Wahoo! Baby's first PR complete 🥳

@ottovlotto
Copy link
Contributor Author

ottovlotto commented Jan 16, 2025

Hey team - just a note, I checked the docs site and it appears the links haven't updated even though this has been approved, looks like something didn't update as expected? @nhussein11

image

@nhussein11
Copy link
Collaborator

Hey @ottovlotto, I’ll check with the team and get back to you

@nhussein11
Copy link
Collaborator

@ottovlotto, we redeployed the website. Your changes are live: https://docs.polkadot.com/polkadot-protocol/architecture/polkadot-chain/pos-consensus/

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants